Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/255#discussion_r49360929
--- Diff: core/sql/generator/GenExplain.cpp ---
@@ -660,6 +660,269 @@ FileScan::addSpecificExplainInfo(ExplainTupleMaster
*explainTuple,
return(explainTuple);
}
+static void appendListOfColumns(Queue* listOfColNames,ComTdb *tdb,
NAString& outNAString){
+
+ if (((ComTdbHbaseAccess*)tdb)->sqHbaseTable()){// if trafodion table
+ char buf[1000];
+
+ listOfColNames->position();
+ for (Lng32 j = 0; j < listOfColNames->numEntries(); j++)
+ {
+ char * currPtr = (char*)listOfColNames->getCurr();
+
+ Lng32 currPos = 0;
+ Lng32 jj = 0;
+ short colNameLen = *(short*)currPtr;
+ currPos += sizeof(short);
+ char colFam[100];
+ while (currPtr[currPos] != ':')
+ {
+ colFam[jj] = currPtr[currPos];
+ currPos++;
+ jj++;
+ }
+ colFam[jj] = ':';
+ jj++;
+ currPos++;
+ colFam[jj] = 0;
+ colNameLen -= jj;
+
+ NABoolean withAt = FALSE;
+ char * colName = &currPtr[currPos];
+ if (colName[0] == '@')
+ {
+ colNameLen--;
+ colName++;
+ withAt = TRUE;
+ }
+
+ Int64 v;
+ if (colNameLen == sizeof(char))
+ v = *(char*)colName;
+ else if (colNameLen == sizeof(unsigned short))
+ v = *(UInt16*)colName;
+ else if (colNameLen == sizeof(Lng32))
+ v = *(ULng32*)colName;
+ else
+ v = 0;
+ if (j==0)
+ str_sprintf(buf, "%s%s%Ld",
+ colFam,
+ (withAt ? "@" : ""),
+ v);
+ else
+ str_sprintf(buf, ",%s%s%Ld",
+ colFam,
+ (withAt ? "@" : ""),
+ v);
+
+ outNAString += buf;
+
+ listOfColNames->advance();
+ } // for
+ }// trafodion tables
+ else
+ {// if hbase native tables
+ char buf[1000];
+
+ listOfColNames->position();
+ for (Lng32 j = 0; j < listOfColNames->numEntries(); j++)
+ {
+ char * currPtr = (char*)listOfColNames->getCurr();
+
+ char * colNamePtr = NULL;
+
+ Lng32 currPos = 0;
+ short colNameLen = *(short*)currPtr;
+ currPos += sizeof(short);
+ char colName[500];
--- End diff --
What I usually use is snprintf(buf, sizeof(buf), ...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
