Github user nonstop-qfchen commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/255#discussion_r49488653
--- Diff: core/sql/generator/GenExplain.cpp ---
@@ -660,6 +660,269 @@ FileScan::addSpecificExplainInfo(ExplainTupleMaster
*explainTuple,
return(explainTuple);
}
+static void appendListOfColumns(Queue* listOfColNames,ComTdb *tdb,
NAString& outNAString){
+
+ if (((ComTdbHbaseAccess*)tdb)->sqHbaseTable()){// if trafodion table
+ char buf[1000];
+
+ listOfColNames->position();
+ for (Lng32 j = 0; j < listOfColNames->numEntries(); j++)
+ {
+ char * currPtr = (char*)listOfColNames->getCurr();
+
+ Lng32 currPos = 0;
+ Lng32 jj = 0;
+ short colNameLen = *(short*)currPtr;
+ currPos += sizeof(short);
+ char colFam[100];
--- End diff --
I personally feel the review process reveals the problems and a rework
process follows. The rework mostly has a focus of the code reviewed, and can
affect the surrounding code.
Most of the concerns raised are about the new code and should be the focus
of rework.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
