Github user hegdean commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/274#discussion_r50450762
  
    --- Diff: install/installer/traf_config_setup ---
    @@ -226,6 +230,33 @@ echo "export NODE_LIST=\"$NODE_LIST\"" >> 
$LOCAL_TRAF_CONFIG
     node_count=$(echo $NODE_LIST | wc -w)
     
     #==============================================
    +echo -n "Are management nodes enabled (Y/N), default is N: "
    +read answer
    + 
    +if [ -z $answer ]; then
    +      echo "export MANAGE_ENABLED=\"N\"" >> $LOCAL_TRAF_CONFIG
    +else
    +      if [[ "${answer}" =~ ^[Yy]$ ]]; then
    --- End diff --
    
    The above 3 lines can be eliminated if the default  variable is 
initialized.. Also instead of MANAGE_ENABLED shall we change it to 
MANAGEMENT_NODES_ENABLED


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to