Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/281#discussion_r50744702
--- Diff: core/sql/sqlcomp/PrivMgrMD.cpp ---
@@ -151,21 +151,19 @@ PrivStatus
PrivMgrMDAdmin::initializeComponentPrivileges()
{
-// First, let's start with a clean slate. Drop all components as well as
-// their respective operations and and any privileges granted. This
should be
-// a NOP unless PrivMgr metadata was damaged and reintialization is
occurring.
-
-PrivMgrComponents components(metadataLocation_,pDiags_);
-
- components.dropAll();
-
// Next, register the component.
PrivStatus privStatus = STATUS_GOOD;
+ // First, let's start with a clean slate. Drop all components as well
as
--- End diff --
Comments need a little wordsmithing perhaps. (We have "First" coming after
"Next.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
