Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/335#discussion_r53814228
  
    --- Diff: 
dcs/src/main/java/org/trafodion/dcs/master/listener/ConnectReply.java ---
    @@ -275,12 +275,10 @@ boolean buildConnectReply  (Header hdr, 
ConnectionContext cc, SocketAddress clie
             if (found == false || exceptionThrown == true){
                 exception.exception_nr = 
ListenerConstants.DcsMasterNoSrvrHdl_exn; //no available servers
                 replyException = true;
    -            if(LOG.isDebugEnabled()){
    -                if (found == false)
    -                    LOG.info(clientSocketAddress + ": " + "No Available 
Servers");
    -                else
    -                    LOG.info(clientSocketAddress + ": " + "No Available 
Servers - exception thrown");
    -            }
    +            if (found == false)
    --- End diff --
    
    It looks like both (found == false) and (exceptionThrown == true) could be 
true. If they are both true, you will log "No Available Servers", but won't 
record that an exception is thrown. Is this what you want?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to