Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/347#discussion_r54508297
--- Diff: core/sql/optimizer/BindRI.cpp ---
@@ -417,12 +450,18 @@ void RefConstraint::getPredicateText(NAString &text,
NAString *corrName) const
{
NAString tblText = ( (corrName == NULL) ?
tblName.getQualifiedNameAsAnsiString() : *corrName);
+ int pos= 0;
text += "(";
for (CollIndex i = 0; i < keyColumns.entries(); i++)
{
- if (i)
+ if(isHiddenColumn(keyColumns[i]->getColName()) )
--- End diff --
Yes, I agree. There are more methods in NAColumn, These names can change
and users can choose their own name for the division columns if they like
(although I would not recommend that). Why are we excluding salt and division
here? It would be best to choose the right one of the many methods in NAColumn:
isUserColumn()
isSystemColumn()
isSyskeyColumn()
isIdentityColumn()
isIdentityColumnByDefault()
isIdentityColumnAlways()
isComputedColumn()
isComputedColumnAlways()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
