Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/364#discussion_r55272540
--- Diff: core/sql/optimizer/ValueDesc.cpp ---
@@ -529,14 +529,13 @@ NABoolean ValueId::isAddedColumnWithNonNullDefault()
const{
default:
break;
}
- if (nac && nac->isAddedColumn() && nac->getDefaultValue())
+ if (nac && nac->getDefaultValue() &&
strcmp(nac->getDefaultValue(),"NULL") != 0)
--- End diff --
Agree with Selva that checking the enum is safer and more maintainable.
Maybe you can make this change in a future check-in, so you don't have to rerun
the regressions just for that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
