Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/371#discussion_r55395195
--- Diff: core/sql/exp/exp_datetime.cpp ---
@@ -91,6 +91,50 @@ copyDatetimeFields(rec_datetime_field startField,
char *dstData,
NABoolean *roundedDownFlag);
+//////////////////////////////////////////////
+// Defined in exp_datetime.h
+//
+// struct DatetimeFormatInfo
+// {
+// Lng32 format;
--- End diff --
Could change the datatype here to an enum, with a slight improvement in
type saftey
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
