Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/376#discussion_r55854436
--- Diff:
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/coprocessor/transactional/SplitBalanceHelper.java
---
@@ -304,11 +304,13 @@ protected void zkCleanup() {
List<String> trafTables = ZKUtil.listChildrenNoWatch(zkw,
zSplitBalPathNoSlash);
List<String> hbaseTables = ZKUtil.listChildrenNoWatch(zkw,
SplitBalanceHelper.zkTable);
- for(String tableName : trafTables) {
+ if(trafTables != null && hbaseTables != null) {
--- End diff --
trafTables should be subset of hbaseTables. If it is just a plain hbase
table, do you think it should be the responsibility of this class to cleanup
the zk nodes. If so, we might need to re-factor this code. If not, this change
should be fine though it is bit more defensive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
