Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/395#discussion_r56853604
--- Diff: core/sql/executor/ExHbaseSelect.cpp ---
@@ -444,6 +444,7 @@ ExWorkProcRetcode ExHbaseScanSQTaskTcb::work(short &rc)
Lng32 retcode = 0;
rc = 0;
Lng32 remainingInBatch = batchSize_;
+ NABoolean isFirstBatch = false;
--- End diff --
Do you want this to be a stack variable? The work method might return at
any time (example: when the parent queue fills up) and then get called again,
which would cause this variable to become false again. I'm wondering if this
variable should be a member instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
