Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/405#discussion_r57803569
  
    --- Diff: core/sql/cli/CliExtern.cpp ---
    @@ -6316,7 +6316,8 @@ Lng32 SQL_EXEC_DeleteHbaseJNI()
           threadContext->incrNumOfCliCalls();
     
           HBaseClient_JNI::deleteInstance();
    -      HiveClient_JNI::deleteInstance();
    +      // The Hive client persists across connections
    +      // HiveClient_JNI::deleteInstance();
    --- End diff --
    
    Good question, and I think any security issues are (or need to be) handled 
in the HiveMetaData object, which already persists between connections. The 
object that now also persists is HiveClient_JNI (and the corresponding Java 
object). Those don't keep a cache or state about Hive metadata, they just have 
methods to read and validate Hive metadata. So, in short, no, I don't believe 
there is a security concern with this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to