Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/436#discussion_r60524273
  
    --- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/TransactionManager.java
 ---
    @@ -549,13 +549,15 @@ public SsccCommitResponse call(SsccRegionService 
instance) throws IOException {
                    retry = false;
                  }
               }
    -          catch (UnknownTransactionException ute) {
    -              LOG.error("Got unknown exception in doCommitX by participant 
" + participantNum
    -                             + " for transaction: " + transactionId + " " 
+ ute);
    -              transactionState.requestPendingCountDec(true);
    -              throw new UnknownTransactionException();
    -          }
               catch (Exception e) {
    +             if(e.toString().contains("UnknownTransactionException")) {
    --- End diff --
    
    Please consider using  e instanceof UnknownTransactionException instead to 
avoid false postives


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to