Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/444#discussion_r61010530
--- Diff: core/sql/generator/GenRelScan.cpp ---
@@ -216,41 +217,56 @@ int HbaseAccess::createAsciiColAndCastExpr(Generator
* generator,
}
if (newGivenType->getTypeQualifier() == NA_CHARACTER_TYPE &&
- (CmpCommon::getDefaultString(HIVE_FILE_CHARSET) == "GBK" ||
CmpCommon::getDefaultString(HIVE_FILE_CHARSET) == "gbk") &&
CmpCommon::getDefaultString(HIVE_DEFAULT_CHARSET) == "UTF8" )
- needTranslate = TRUE;
-
+ (CmpCommon::getDefaultString(HIVE_FILE_CHARSET) == "GBK" ||
--- End diff --
Don't we case-shift these things before we get this far? Otherwise we have
to worry about variants such as Gbk, gBK, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
