Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/482#discussion_r63438426
  
    --- Diff: install/installer/traf_config_check ---
    @@ -702,7 +702,7 @@ function checkClouderaVersion {
     if [[ $CDH_5_3_HDP_2_2_SUPPORT == "N" ]]; then
        #Check that Cloudera 5.2 or 5.3 are not installed.
        if [[ "$CDH_5_4_SUPPORT" == "Y" ]] || [[ "$CDH_5_5_SUPPORT" == "Y" ]]; 
then
    -      nameOfVersion=$(ssh -q -n $node grep "Version" 
$HOME/hbaseVersion.txt | sed 's/,.*//' | sed 's/.*\-//' | grep cdh5.[4-6].*)
    +      nameOfVersion=$(ssh -q -n $node grep "Version" 
$HOME/hbaseVersion.txt | sed 's/,.*//' | sed 's/.*\-//' | grep cdh5.4.*)
    --- End diff --
    
    Not sure I get it. The "IF" includes the condition $CDH_5_5_SUPPORT, yet we 
don't look for 5.5? Should the "IF" change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to