Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/499#discussion_r64833315
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -6004,10 +6013,13 @@ enum DefaultConstants NADefaults::holdOrRestore
(const char *attrName,
char * value = NULL;
if (holdOrRestoreCQD == 1) // hold cqd
{
- if (heldDefaults_[attrEnum])
- {
- NADELETEBASIC(heldDefaults_[attrEnum], NADHEAP);
- }
+ if (heldHeldDefaults_[attrEnum])
+ {
+ // Gasp! We've done three successive HOLDs... it's off to
+ // the bit bucket for the deepest value
+ NADELETEBASIC(heldHeldDefaults_[attrEnum], NADHEAP);
--- End diff --
My preference as a user would be an assert instead of incorrect behavior.
But this is probably a very little-used feature, so I doubt anyone will run
into this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
