Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/541#discussion_r66859529
--- Diff:
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/IdTm.java
---
@@ -122,13 +124,67 @@ public void id(int timeout, IdTmId id) throws
IdTmException {
LOG.error("native_id returned: " + err + " Throwing
IdTmException");
throw new IdTmException("ferr=" + err);
}
+ if (id.val == 0) {
+ LOG.error("native_id returned id: " + id.val + " err: " +
err + ", Throwing IdTmException");
--- End diff --
Doesn't hurt anything to report err here,, but you already know in this
code path that err == 0 due to the preceding if + throw.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
