Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/542#discussion_r66891751
  
    --- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/coprocessor/transactional/TrxRegionEndpoint.java.tmpl
 ---
    @@ -359,7 +359,7 @@ CoprocessorService, Coprocessor {
       private static final int DEFAULT_SLEEP = 60 * 1000;
       private static final int DEFAULT_MEMORY_THRESHOLD = 100; // 100% memory 
used
    --- End diff --
    
    I see. Perhaps add a new "private static final int" for your new usage? For 
example, "private static final int DEFAULT_STARTUP_MEMORY_THRESHOLD = 90;". 
Just a stylistic nit. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to