Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/550#discussion_r67720952
  
    --- Diff: core/sql/executor/ExHbaseAccess.cpp ---
    @@ -1153,6 +1153,32 @@ Lng32 
ExHbaseAccessTcb::createSQRowFromHbaseFormat(Int64 *latestRowTimestamp)
                  ex_assert(FALSE, "Attr not found -2");
          
          char * defVal = attr->getDefaultValue();
    +          if (! defVal)
    +            {
    +              char * colVal = (char*)
    +                hbaseAccessTdb().listOfFetchedColNames()->get(idx);
    +
    +              Text colFam, colName;
    +              extractColFamilyAndName(colVal, colFam, colName);
    +
    +              Int64 v = 0;
    +              if (colName.length() == sizeof(char))
    +                v = *(char*)colName.data();
    +              else if (colName.length() == sizeof(unsigned short))
    +                v = *(UInt16*)colName.data();
    +              else if (colName.length() == sizeof(Lng32))
    --- End diff --
    
    Should be sizeof(ULng32), but since that is the same as sizeof(Lng32), this 
is an unobservable bug


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to