Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/552#discussion_r67894795
--- Diff: core/sql/common/CharType.cpp ---
@@ -942,7 +942,8 @@ SQLVarChar::SQLVarChar(Lng32 maxLen,
FALSE, allowSQLnull, isUpShifted, isCaseInsensitive,
TRUE, cs, co, ce,
encoding, vcIndLen),
- clientDataType_(collHeap()) // Get heap from NABasicObject. Can't
allocate on stack.
+ clientDataType_(collHeap()), // Get heap from NABasicObject. Can't
allocate on stack.
+ wasHiveString_(FALSE)
--- End diff --
I'm confused by the name. The string was a Hive string but it isn't any
longer? Why should we care? (I imagine I'll find the answer later... there is
some different semantic that we want downstream...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
