Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/590#discussion_r70331537
--- Diff: core/sql/common/MiscType.cpp ---
@@ -106,21 +172,51 @@ const NAType* SQLBoolean::synthesizeType(enum
NATypeSynthRuleEnum synthRule,
// expressions.
//
if (synthRule == SYNTH_RULE_UNION)
- return new(h) SQLBoolean();
+ return new(h) SQLBooleanNative
+ (operand1.supportsSQLnull() || operand2.supportsSQLnull());
+
return NULL;
} // synthesizeType()
+void SQLBooleanNative::minRepresentableValue(void* bufPtr, Lng32* bufLen,
+ NAString ** stringLiteral,
+ CollHeap* h) const
+{
+ assert(*bufLen >= sizeof(Int8));
+ Lng32 valueBuf;
--- End diff --
It doesn't hurt anything, but it looks like valueBuf is not used other than
setting it to zero three lines down.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
