Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/594#discussion_r70990583
--- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
@@ -4967,10 +4967,40 @@ odbc_SQLSvc_GetSQLCatalogs_sme_(
"and (ob.SCHEMA_NAME = '%s' or trim(ob.SCHEMA_NAME)
LIKE '%s' ESCAPE '\\') "
"and (ob.OBJECT_NAME = '%s' or trim(ob.OBJECT_NAME)
LIKE '%s' ESCAPE '\\') "
"and (ob.OBJECT_TYPE in ('BT', 'VI')) "
- "and (trim(co.COLUMN_CLASS) not in('S', 'M'));",
+ "and (trim(co.COLUMN_CLASS) not in('S', 'M')) "
+ "union "
+ "select "
+ "cast('%s' as varchar(128)) TABLE_CAT, "
+ "cast(trim(ob.SCHEMA_NAME) as varchar(128))
TABLE_SCHEM, "
+ "cast(trim(ob.OBJECT_NAME) as varchar(128))
TABLE_NAME, "
+ "cast(idx.is_unique as smallint) NON_UNIQUE, "
+ "cast('' as varchar(128)) INDEX_QUALIFIER, "
+ "cast(trim(ob_table.OBJECT_NAME) as varchar(128))
INDEX_NAME, "
+ "cast(3 as smallint) TYPE, "
+ "cast(0 as smallint) ORDINAL_POSITION, "
+ "cast('' as varchar(128)) COLUMN_NAME, "
+ "cast('' as char(1)) ASC_OR_DES, "
--- End diff --
Spec says NULL should be returned when the value is not available. Can you
please change it to NULL. Attaching a formatted output of this query when the
table has index would be helpful to validate the results of the query by the
reviewers. Consider creating a use case with two tables one with update
statistics performed and another without.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
