Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/593#discussion_r71015190
  
    --- Diff: core/sql/executor/ExHbaseAccess.cpp ---
    @@ -2967,22 +2968,28 @@ void ExHbaseAccessTcb::handleException(NAHeap *heap,
                                         ComCondition *errorCond,
                                         ExpHbaseInterface * ehi,
                                         NABoolean & LoggingFileCreated,
    -                                    char *loggingFileName)
    +                                    char *loggingFileName,
    +                                    ComDiagsArea **loggingErrorDiags)
     {
       Lng32 errorMsgLen = 0;
       charBuf *cBuf = NULL;
       char *errorMsg;
       Lng32 retcode;
     
    +  if (*loggingErrorDiags != NULL)
    --- End diff --
    
    Basically, we want to skip the error rows in the source and continue to 
load. Load command has constructs to log the error row and the error 
information about it.  We just want to report the error while logging the error 
rows as warning at the end of the load command. This check is skipping the 
logging once an error is encountered  in the earlier attempt to log the error 
row.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to