Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/599#discussion_r71351960
  
    --- Diff: 
core/sqf/src/seatrans/tm/hbasetmlib2/src/main/java/org/trafodion/dtm/HBaseTxClient.java
 ---
    @@ -694,7 +694,22 @@ public short callCreateTable(long transactionId, 
byte[] pv_htbldesc, Object[]  b
              LOG.error("Error while getting HTableDescriptor caused by : ", 
de);
              throw new IOException("Error while getting HTableDescriptor 
caused by : ", de);
           }
    -      trxManager.createTable(ts, htdesc, beginEndKeys);
    +      try {
    +         trxManager.createTable(ts, htdesc, beginEndKeys);
    +      }
    +      catch (IOException cte) {
    +         if (LOG.isTraceEnabled()) 
LOG.trace("HBaseTxClient:callCreateTable exception trxManager.createTable, 
retval: " +
    +            TransReturnCode.RET_EXCEPTION.toString() +" txid: " + 
transactionId +" Exception: " + cte);
    +         StringWriter sw = new StringWriter();
    +         PrintWriter pw = new PrintWriter(sw);
    +         cte.printStackTrace(pw);
    --- End diff --
    
    703-705 can be avoided. All the printStackTrace calls were removed as part 
of java exception handling cleanup. Instead you can LOG.error(<message>, e) 
methods


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to