Github user traflm commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/672#discussion_r76384092
--- Diff: core/sqf/src/tm/tmddlrequests.cpp ---
@@ -39,13 +40,24 @@ JNIEXPORT void JNICALL
Java_org_apache_hadoop_hbase_client_transactional_RMInter
char la_tbldesc[TM_MAX_DDLREQUEST_STRING];
char la_tblname[TM_MAX_DDLREQUEST_STRING];
char* str_key;
- str_key = new char[TM_MAX_DDLREQUEST_STRING];
+ if(pv_keyLength <= 0)
+ {
+ cout << "createTableReq bad input pv_keyLength, abort" << endl;
+ abort();
+ }
+ str_key = new char[pv_keyLength];
--- End diff --
thanks Prashanth, yes, I should add this check. Will fix it and submit
again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
