Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/697#discussion_r78640979
--- Diff:
core/sql/src/main/java/org/trafodion/sql/udr/LmUDRObjMethodInvoke.java ---
@@ -68,7 +68,7 @@ static LmUDRObjMethodInvoke makeNewObj(
return result;
}
- public static class ReturnInfo
+ public class ReturnInfo
--- End diff --
Just curious, I don't see a code change that makes this necessary, why are
we changing the static class to an inner class? Wouldn't the static class be
preferable, especially given that we pass it - without an object from the
parent class - via JNI? My knowledge about this difference comes from
https://docs.oracle.com/javase/tutorial/java/javaOO/nested.html, am not a real
expert in Java nested classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
