Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/715#discussion_r79644833
  
    --- Diff: core/sqf/src/tm/tmddlrequests.cpp ---
    @@ -40,14 +40,21 @@ JNIEXPORT jint JNICALL 
Java_org_apache_hadoop_hbase_client_transactional_RMInter
        char la_tbldesc[TM_MAX_DDLREQUEST_STRING];
        char la_tblname[TM_MAX_DDLREQUEST_STRING];
        char* str_key;
    -   str_key = new char[TM_MAX_DDLREQUEST_STRING];
        char** la_keys;
        la_keys = new char *[TM_MAX_DDLREQUEST_STRING];
        int lv_error = FEOK;
     
    +   if(pv_keyLength <= 0 || pv_keyLength >= TM_MAX_DDLREQUEST_STRING)
    +   {
    +     cout << "Table key length is larger than max allowed" << endl;
    +     return FEBADKEYDESC;
    +   }
    +   str_key = new char[pv_keyLength];
    +
        int lv_tblname_len = pp_env->GetArrayLength(pv_tblname);
        if(lv_tblname_len > TM_MAX_DDLREQUEST_STRING) {
           cout << "Table name length is larger than max allowed" << endl;
    +      return FEBADNAME;
    --- End diff --
    
    A leak of str_key here, could delete it before returning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to