Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/713#discussion_r79923294
  
    --- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/SsccTransactionalTable.java
 ---
    @@ -274,6 +278,48 @@ public SsccDeleteTransactionalResponse 
call(SsccRegionService instance) throws I
                   throw new IOException(resultArray[0].getException());
               }
     
    +    public void deleteRegionTx(final long tid, final Delete delete, final 
boolean autoCommit) throws IOException {
    +      SingleVersionDeleteNotSupported.validateDelete(delete);
    +      final String regionName = 
super.getRegionLocation(delete.getRow()).getRegionInfo().getRegionNameAsString();
    +         Batch.Call<SsccRegionService, SsccDeleteRegionTxResponse> 
callable =
    +                new Batch.Call<SsccRegionService, 
SsccDeleteRegionTxResponse>() {
    +            ServerRpcController controller = new ServerRpcController();
    +            BlockingRpcCallback<SsccDeleteRegionTxResponse> rpcCallback =
    +            new BlockingRpcCallback<SsccDeleteRegionTxResponse>();
    +
    +            public SsccDeleteRegionTxResponse call(SsccRegionService 
instance) throws IOException {
    --- End diff --
    
    Just curious: Why no @Override here? (I saw one in a similar method down 
below.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to