Github user anoopsharma00 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/733#discussion_r81142262
  
    --- Diff: core/sql/optimizer/RelCache.cpp ---
    @@ -418,6 +418,10 @@ void GroupByAgg::generateCacheKey(CacheWA &cwa) const
         groupExpr_.rebuildExprTree(ITM_ITEM_LIST);
       if (grpExpr) { 
         cwa += " gBy:"; 
    +
    +    if (isRollup())
    +      cwa += " roll:";
    +
    --- End diff --
    
    yes, good point. Tried it and it does incorrectly caches them.
    Will fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to