Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/743#discussion_r81870441
  
    --- Diff: core/sql/sort/Record.cpp ---
    @@ -55,11 +55,23 @@ Record::Record(ULng32 size, NABoolean doNotallocRec, 
CollHeap* heap)
       }
     }
     
    +Record::Record(void *rec, ULng32 reclen, void* tupp, CollHeap* heap, 
SortError* sorterror)
    +{
    +    recSize_   = reclen;
    --- End diff --
    
    There are some indentation problems that make some of the code hard to 
read. If you're using tabs, set your editor to replace with spaces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to