Github user prashanth-vasudev commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/768#discussion_r84178660
--- Diff:
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/TransactionManager.java
---
@@ -1300,11 +1380,14 @@ public Integer doPrepareX(final
List<TransactionRegionLocation> locations, final
commitErr = TransactionalReturn.COMMIT_UNSUCCESSFUL;
canCommit = false;
readOnly = false;
+ LOG.warn(errMsg);
transactionState.addRegionToIgnore(locations.get(resultCount)); // No need to
re-abort.
break;
default:
- LOG.warn("Received invalid return code from requestCommit " +
commitStatus + " for transaction " + transactionId + " throwing
CommitUnsuccessfulException");
- throw new CommitUnsuccessfulException("Unexpected return code
from prepareCommit: " + commitStatus);
+ CommitUnsuccessfulException cue = new
CommitUnsuccessfulException(errMsg);
+ if (LOG.isWarnEnabled())
--- End diff --
This can be logged as error unconditionally since it is pretty significant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
