Github user arvind-narain commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/775#discussion_r85281913
--- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
@@ -4556,6 +4556,8 @@ odbc_SQLSvc_GetSQLCatalogs_sme_(
"cast(0 as smallint), cast(0 as
smallint), cast(3 as smallint), cast(0 as smallint)),"
"('BIGINT SIGNED', -5, 19, NULL, NULL,
NULL, 1, 0, 2, 0, 0, 0, 'LARGEINT', NULL, NULL, 'SIGNED LARGEINT', 10, 19, 20,
-402, NULL, NULL, 0, 0, 3, 0),"
"('CHAR', 1, 32000, '''', '''', 'max
length', 1, 1, 3, NULL, 0, NULL, 'CHARACTER', NULL, NULL, 'CHARACTER', NULL,
-1, -1, 1, NULL, NULL, 0, 0, 3, 0),"
+ "('NCHAR', -8, 32000, '''', '''', 'max
length', 1, 1, 3, NULL, 0, NULL, 'WCHAR', NULL, NULL, 'CHARACTER', NULL, -1,
-1, -8, NULL, NULL, 0, 0, 3, 0),"
+ "('NCHAR VARYING', -9, 32000, '''', '''',
'max length', 1, 1, 3, NULL, 0, NULL, 'WCHAR VARYING', NULL, NULL, 'CHARACTER',
NULL, -1, -1, -9, NULL, NULL, 0, 0, 3, 0),"
--- End diff --
Changes look good to me. Do check if this should be 'VARCHAR' rather than
'CHARACTER'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
