Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/794#discussion_r85448965
  
    --- Diff: core/sql/executor/ExHdfsScan.cpp ---
    @@ -1700,6 +1714,138 @@ char * 
ExHdfsScanTcb::extractAndTransformAsciiSourceToSqlRow(int &err,
       return NULL;
     }
     
    +void ExHdfsScanTcb::computeRangesAtRuntime()
    --- End diff --
    
    I suppose this computation is being repeated by each esp. Is there a way by 
which it can done once and shared (say computed during fixup)? If possible, 
this would be a minor enhancement for later. I do see some comment indicating 
that only portions relevant to this esp are computed. Maybe some comment 
including a statement on which locality_balance_level this corresponds to will 
help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to