Github user prashanth-vasudev commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/815#discussion_r86498129
--- Diff: core/sql/executor/ex_sort.h ---
@@ -356,4 +363,119 @@ class ExSortFromTopPrivateState : public
ex_tcb_private_state
~ExSortFromTopPrivateState(); // destructor
};
+class ExSortBufferPool : public NABasicObject
--- End diff --
Creating a abstract class here was considered as the first option. However,
making this change would have ripple effect all over the code since
sql_buffer_pool is packed and unpacked when hopping many operators. If a major
change is made to sql buffer management in future, it would be nice to consider
having a abstract class. For now, to keep the change concise, this approach was
taken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
