Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/846#discussion_r89167830
  
    --- Diff: core/sql/comexe/ComTdbExeUtil.h ---
    @@ -2946,37 +2946,65 @@ class ComTdbExeUtilLobShowddl : public ComTdbExeUtil
     
     static const ComTdbVirtTableColumnInfo hiveMDTablesColInfo[] =
     {                                                                          
           
    -  { "CATALOG_NAME",   0,      COM_USER_COLUMN, REC_BYTE_F_ASCII,    256, 
FALSE , SQLCHARSETCODE_UNKNOWN, 0, 0, 0, 0, 0, 0, 0, COM_NO_DEFAULT, "" 
,NULL,NULL,COM_UNKNOWN_DIRECTION_LIT, 0},  
    -  { "SCHEMA_NAME",     1,    COM_USER_COLUMN, REC_BYTE_F_ASCII,    256, 
FALSE , SQLCHARSETCODE_UNKNOWN, 0, 0, 0, 0, 0, 0, 0, COM_NO_DEFAULT, "" 
,NULL,NULL,COM_UNKNOWN_DIRECTION_LIT, 0},  
    -  { "TABLE_NAME",        2,     COM_USER_COLUMN, REC_BYTE_F_ASCII,    256, 
FALSE , SQLCHARSETCODE_UNKNOWN, 0, 0, 0, 0, 0, 0, 0, COM_NO_DEFAULT, 
"",NULL,NULL,COM_UNKNOWN_DIRECTION_LIT, 0}
    +  { "CATALOG_NAME",   0,      COM_USER_COLUMN, REC_BYTE_F_ASCII,    256, 
FALSE , SQLCHARSETCODE_UTF8,     0, 0, 0, 0, 0, 0, 0, COM_NO_DEFAULT, "" 
,NULL,NULL,COM_UNKNOWN_DIRECTION_LIT, 0},  
    +  { "SCHEMA_NAME",    1,      COM_USER_COLUMN, REC_BYTE_F_ASCII,    256, 
FALSE , SQLCHARSETCODE_UTF8,     0, 0, 0, 0, 0, 0, 0, COM_NO_DEFAULT, "" 
,NULL,NULL,COM_UNKNOWN_DIRECTION_LIT, 0},  
    +  { "TABLE_NAME",     2,      COM_USER_COLUMN, REC_BYTE_F_ASCII,    256, 
FALSE , SQLCHARSETCODE_UTF8,     0, 0, 0, 0, 0, 0, 0, COM_NO_DEFAULT, "" 
,NULL,NULL,COM_UNKNOWN_DIRECTION_LIT, 0},
    +  { "FILE_FORMAT",    3,      COM_USER_COLUMN, REC_BYTE_F_ASCII,     24, 
FALSE , SQLCHARSETCODE_ISO88591, 0, 0, 0, 0, 0, 0, 0, COM_NO_DEFAULT, "" 
,NULL,NULL,COM_UNKNOWN_DIRECTION_LIT, 0},
    +  { "CREATE_TIME",    4,      COM_USER_COLUMN, REC_BIN64_SIGNED,      8, 
FALSE , SQLCHARSETCODE_UNKNOWN,  0, 0, 0, 0, 0, 0, 0, COM_NO_DEFAULT, "" 
,NULL,NULL,COM_UNKNOWN_DIRECTION_LIT, 0},
    --- End diff --
    
    Why do we use LARGEINT for times instead of TIMESTAMP? (Yes, I know we do 
this too in our metadata.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to