Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/878#discussion_r92717984
--- Diff: core/sql/generator/GenExpGenerator.h ---
@@ -1086,45 +1073,7 @@ class ExpGenerator : public NABasicObject
const SearchKey * searchKey,
const MdamKey * mdamKey,
const NABoolean reverseScan,
- unsigned short keytag,
- const ExpTupleDesc::TupleDataFormat tf,
-
- // the next few parameters are here
- // as part of a horrible kludge for
- // the PartitionAccess::codeGen()
- // method, which lacks a SearchKey
- // object and therefore exposes
- // things like the exclusion
- // expressions; with luck, later work
- // in the Optimizer will result in a
- // much cleaner interface
- const NABoolean useTheHorribleKludge = FALSE,
--- End diff --
Glad to see this finally removed/replaced. I remember putting this in
around 1996 to fix some issue with the interaction of MDAM and partition access.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
