Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/885#discussion_r93671479
  
    --- Diff: core/sqf/inc/cextdecs/cextdecs.h ---
    @@ -289,6 +289,10 @@ _declspec(dllimport) short   DNUMOUT
     
     _declspec(dllimport) short   ENDTRANSACTION();
     
    +//errStr is allocated if errlen is not zero. Caller must deallocate errStr.
    +//Rest of functionality same as ENDTRANSACTION();
    +_declspec(dllimport) short   ENDTRANSACTION_ERR(char *&errStr, int 
&errlen);
    --- End diff --
    
    This would mean that the errStr is allocated by the TM functions using its 
own heap management scheme or the system memory. The caller wouldn't be aware 
of how to deallocate if it is anything other than system memory


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to