Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/885#discussion_r93672570
--- Diff: core/sqf/src/seatrans/tm/hbasetmlib2/javaobjectinterfacetm.cpp ---
@@ -428,6 +428,42 @@ bool
JavaObjectInterfaceTM::getExceptionDetails(JNIEnv *jenv)
return true;
}
--- End diff --
It would be better use the existing getExceptionDetails function to avoid
duplication of code. You can either to choose to have default parameter or make
the existing getExceptionDetails to call the new functions with retCode passed
in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
