Github user nonstop-qfchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/918#discussion_r97323697
  
    --- Diff: core/sql/executor/ExStats.cpp ---
    @@ -2741,13 +2749,21 @@ Int64 ExHbaseAccessStats::getNumVal(Int32 i) const
     
     NABoolean ExHbaseAccessStats::filterForSEstats(struct timespec 
currTimespec, Lng32 filter)
     {
    -   blockTime_ = timer_.filterForSEstats(currTimespec);
    -   if (blockTime_ >= filter)
    -      return TRUE;
    +   Int64 sumIOTime;
    --- End diff --
    
    The same logic seems duplicated between this class and ExHdfsScanStats.  
Maybe some refactoring? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to