Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/929#discussion_r97919059
--- Diff: core/sql/executor/HBaseClient_JNI.cpp ---
@@ -1319,17 +1334,21 @@ HBC_RetCode HBaseClient_JNI::estimateRowCount(const
char* tblName,
jint jPartialRowSize = partialRowSize;
jint jNumCols = numCols;
+ jint jRetryLimitMilliSeconds = retryLimitMilliSeconds;
jlongArray jRowCount = jenv_->NewLongArray(1);
tsRecentJMFromJNI = JavaMethods_[JM_EST_RC].jm_full_name;
jboolean jresult = jenv_->CallBooleanMethod(javaObj_,
JavaMethods_[JM_EST_RC].methodID,
js_tblName, jPartialRowSize,
- jNumCols, jRowCount);
+ jNumCols,
jRetryLimitMilliSeconds, jRowCount);
jboolean isCopy;
jlong* arrayElems = jenv_->GetLongArrayElements(jRowCount, &isCopy);
rowCount = *arrayElems;
if (isCopy == JNI_TRUE)
jenv_->ReleaseLongArrayElements(jRowCount, arrayElems, JNI_ABORT);
+ jenv_->DeleteLocalRef(js_tblName);
--- End diff --
popLocalFrame would do this for you. Again I cleaned this code earlier to
remove the unnecessary call to DeleteLocalRef if push/pop local frame is used
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
