Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/953#discussion_r100865729
--- Diff: core/sql/cli/Globals.cpp ---
@@ -322,6 +310,18 @@ void CliGlobals::init( NABoolean espProcess,
capacities_.setHeap(defaultContext_->exCollHeap());
freespaces_.setHeap(defaultContext_->exCollHeap());
largestFragments_.setHeap(defaultContext_->exCollHeap());
+ if (statsGlobals_ != NULL)
+ memMonitor_ = statsGlobals_->getMemoryMonitor();
--- End diff --
Now that the memory monitor resides in another process, I think we need to
make any of its methods that shouldn't be called by the executor thread
private, like update() and updatePageFaultRate(). It would also be good to
update the comments in memorymonitor.h to indicate which calls are meant for
consumers and which ones are potentially in a separate thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
