Github user arvind-narain commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1036#discussion_r109077021
  
    --- Diff: core/conn/jdbc_type2/Makefile ---
    @@ -57,7 +57,15 @@ T2_OBJS  = $(OUTDIR)/CommonDiags.o \
            $(OUTDIR)/ResStatisticsStatement.o \
            $(OUTDIR)/Vproc.o \
            $(OUTDIR)/type2version.o
    -
    +CSES := org.trafodion.jdbc.t2.JdbcDebug \
    +           org.trafodion.jdbc.t2.DataWrapper \
    +           org.trafodion.jdbc.t2.SQLMXCallableStatement \
    +           org.trafodion.jdbc.t2.SQLMXConnection \
    +           org.trafodion.jdbc.t2.SQLMXDatabaseMetaData \
    +           org.trafodion.jdbc.t2.T2Driver \
    +           org.trafodion.jdbc.t2.SQLMXPreparedStatement \
    +           org.trafodion.jdbc.t2.SQLMXResultSet \
    +           org.trafodion.jdbc.t2.SQLMXStatement
    --- End diff --
    
    Would this change be needed if we touch the package name in T2 source to 
include apache ? Should we change the package name (org.apache.trafodion...) in 
the source and the file layout  to make it consistent ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to