Github user traflm commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1055#discussion_r110632142
--- Diff: core/sql/executor/ExHdfsScan.cpp ---
@@ -1653,7 +1653,7 @@ char *
ExHdfsScanTcb::extractAndTransformAsciiSourceToSqlRow(int &err,
// for non-varchar, length of zero indicates a null
value.
// For all datatypes, HIVE_DEFAULT_NULL_STRING('\N')
indicates a null value.
if (((len == 0) && (tgtAttr && (NOT
DFS2REC::isSQLVarChar(tgtAttr->getDatatype())))) ||
- ((len > 0) && (memcmp(sourceData,
HIVE_DEFAULT_NULL_STRING, len) == 0)))
+ ((len > 1) && (memcmp(sourceData,
HIVE_DEFAULT_NULL_STRING, len) == 0)))
--- End diff --
This can handle the '\' problem, but if (not possible) the user define '\'
as null, this logic will break.
So here, it should be to compare the whole HIVE_DEFAULT_NULL_STRING, and
make sure length is equal, as I understand.
\N is NULL, but \NA is not NULL, what will happen if there is \NAA ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
