Github user DaveBirdsall commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1078#discussion_r114609693
  
    --- Diff: core/conn/unixodbc/odbc/odbcclient/unixcli/cli/sqltocconv.cpp ---
    @@ -1555,6 +1555,7 @@ unsigned long ODBC::ConvertSQLToC(SQLINTEGER  
ODBCAppVersion,
                                                                return 
IDS_22_003;
                                                        }
                                                        srcLength = 
TransStringLength + 1;
    +                            DataLen = sizeof(DATE_STRUCT);
    --- End diff --
    
    I don't understand why this code change is correct. It looks like we are 
converting between a variety of C numeric types and ODBC varchar types. Why 
would DATE enter into it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to