Github user zcorrea commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1077#discussion_r115490249
--- Diff: install/python-installer/scripts/traf_sqconfig.py ---
@@ -51,18 +52,15 @@ def run():
lines.append(line)
lines.append('end node\n')
- lines.append('\n')
- lines.append('begin overflow\n')
-
- for scratch_loc in scratch_locs:
- line = 'hdd %s\n' % scratch_loc
- lines.append(line)
-
- lines.append('end overflow\n')
+ # write out the node section
with open(sqconfig_file, 'w') as f:
f.writelines(lines)
+ # append the current persist section to the Trafodion configuration
file
+ run_cmd('echo "sed \'1,20d\' %s >> %s"' % (sqconfig_persist_file,
sqconfig_file))
+ run_cmd('sed \'1,20d\' %s >> %s' % (sqconfig_persist_file,
sqconfig_file))
--- End diff --
On stripping the header comments out, the target file already has the same
Copyright information.
On concatenating, yes, the sqgen should probably be modified to pull in the
persist file directly after processing the node section on the 'sqconfig' file.
Good suggestion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
