Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1098#discussion_r118051474
--- Diff:
core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4PreparedStatement.java
---
@@ -1051,10 +1054,29 @@ public void setLong(int parameterIndex, long x)
throws SQLException {
}
validateSetInvocation(parameterIndex);
inputDesc_[parameterIndex -
1].checkValidNumericConversion(connection_.getLocale());
- Utility.checkLongBoundary(connection_.getLocale(),
BigDecimal.valueOf(x));
addParamValue(parameterIndex, Long.toString(x));
}
+ private void setLong(int parameterIndex, BigDecimal x) throws
SQLException {
+ if (connection_.props_.t4Logger_.isLoggable(Level.FINE) ==
true) {
+ Object p[] =
T4LoggingUtilities.makeParams(connection_.props_, parameterIndex, x);
+ connection_.props_.t4Logger_.logp(Level.FINE,
"TrafT4PreparedStatement", "setLong", "", p);
+ }
+ if (connection_.props_.getLogWriter() != null) {
+ LogRecord lr = new LogRecord(Level.FINE, "");
--- End diff --
Looks like all these statements will be executed and the objects created,
but thrown away because the level is not set to FINE. Or in other words when
will be the getLogWriter() be NULL?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
