Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1109#discussion_r120198661
--- Diff: core/sql/ustat/hs_parser.cpp ---
@@ -178,89 +178,24 @@ Lng32 AddTableName( const hs_table_type type
}
else
{
- // When CQD DEFAULT_SCHEMA_ACCESS_ONLY is on,
- // users cannot update stats on tables not in the default/public
schemas.
- if ( schema &&
-
ActiveSchemaDB()->getDefaults().getToken(DEFAULT_SCHEMA_ACCESS_ONLY)==DF_ON )
- {
- SchemaName objSchName;
- NAString curSchName(schema);
- NAString curCatName;
- objSchName.setSchemaName(curSchName);
- if (catalog)
- {
- curCatName = catalog;
- objSchName.setCatalogName(curCatName);
- }
- else
- curCatName =
ActiveSchemaDB()->getDefaultSchema().getCatalogName();
-
- // If the schema is neither default nor public,
- // issue inaccessible error.
- if (!objSchName.matchDefaultPublicSchema())
- {
- NAString dataObj(curCatName);
- if (!dataObj.isNull()) dataObj += ".";
- dataObj += curSchName + ".";
- dataObj += table;
- HSFuncMergeDiags(-UERR_OBJECT_INACCESSIBLE, dataObj.data());
- retcode = -1;
- HSHandleError(retcode);
- }
- }
-
if (catalog)
catName = catalog;
else
{
- // LCOV_EXCL_START :nsk
- if (SqlParser_NAMETYPE == DF_NSK)
- {
- catName = SqlParser_MPLOC.getSysDotVol();
- hs_globals->tableType = GUARDIAN_TABLE;
- hs_globals->tableFormat = SQLMP;
- }
- else
- // LCOV_EXCL_STOP
- catName =
ActiveSchemaDB()->getDefaultSchema().getCatalogName();
+ catName =
ActiveSchemaDB()->getDefaultSchema().getCatalogName();
--- End diff --
Thank you for getting rid of the NSK anachronisms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
