Github user Weixin-Xu commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1110#discussion_r120249395
--- Diff: core/conn/unixodbc/odbc/odbcclient/unixcli/cli/cdesc.cpp ---
@@ -2381,7 +2381,8 @@ SQLRETURN CDesc::BuildValueList(CStmt *pHandle,
//AMR - changed this pointer ty
if(IPDDescRecPtr->m_ODBCDataType == SQL_VARCHAR
||
IPDDescRecPtr->m_ODBCDataType ==
SQL_LONGVARCHAR ||
- IPDDescRecPtr->m_ODBCDataType == SQL_CHAR)
+ IPDDescRecPtr->m_ODBCDataType == SQL_CHAR &&
+ IPDDescRecPtr->m_SQLDataType != SQLTYPECODE_BOOLEAN)
--- End diff --
when SQLDataType return SQLTYPECODE_BOOLEAN, ODBCDataType perform SQL_CHAR
then code will make len-1.
It's unneccessary operation, so skip these code when meeting boolean type.
So VARCHAR or LONG VARCHAR or ( CHAR and not BOOLEAN) is my meaning, and
add () will be better
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
