Github user DaveBirdsall commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1192#discussion_r130491826
  
    --- Diff: core/sqf/monitor/linux/commaccept.cxx ---
    @@ -33,6 +33,7 @@ using namespace std;
     #include <signal.h>
     #include <unistd.h>
     
    +extern CCommAccept CommAccept;
    --- End diff --
    
    Global objects cause race conditions at exit time. Their destructors are 
called in non-deterministic order. Does this object depend on any other 
objects? Does its destructor traverse to any other objects? If so, then this 
will probably break at some time in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to