Github user sandhyasun commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1225#discussion_r138252548
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
    @@ -6489,6 +6506,31 @@ odbc_SQLSrvr_ExtractLob_sme_(
                     exception_->u.SQLError.errorList._buffer = 
QryLobExtractSrvrStmt->sqlError.errorList._buffer;
                     exception_->u.ParamError.ParamDesc = 
SQLSVC_EXCEPTION_EXECUTE_FAILED;
                 }
    +
    +            IDL_long_long zeroValue = 0;
    +            snprintf(LobExtractQuery, sizeof(LobExtractQuery), "EXTRACT 
LOBTOBUFFER(LOB'%s', LOCATION %Ld, SIZE %Ld)", lobHandle, (Int64)lobDataValue, 
&zeroValue);
    +
    +            retcode = QryLobExtractSrvrStmt->ExecDirect(NULL, 
LobExtractQuery, EXTERNAL_STMT, TYPE_CALL, SQL_ASYNC_ENABLE_OFF, 0);
    +
    --- End diff --
    
    This seems like a big restriction since we will allow a max of 512 MB only. 
 This means the user cannot even havea picture file of 1 G or 2 G in this 
release ?  How about for update lob ?  Will the caller be able to use "update 
lob  <lobhandle> append " several times to append data to a single lob ?


---

Reply via email to