Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1231#discussion_r138773979
--- Diff: core/sql/cli/Cli.cpp ---
@@ -8325,19 +8325,15 @@ Lng32 SQLCLI_RegisterQuery(CliGlobals *cliGlobals,
StatsGlobals *statsGlobals = cliGlobals->getStatsGlobals();
if (statsGlobals == NULL)
return retcode;
- short error;
- short savedPriority, savedStopMode;
+ int error;
error = statsGlobals->getStatsSemaphore(cliGlobals->getSemId(),
- cliGlobals->myPin(),
- savedPriority, savedStopMode, FALSE /*shouldTimeout*/);
- ex_assert(error == 0, "getStatsSemaphore() returned an error");
-
+ cliGlobals->myPin());
--- End diff --
Why do we ignore the error?
---
